Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix validation: file_size #13

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Conversation

HuangXiaoyan0106
Copy link
Contributor

@HuangXiaoyan0106 HuangXiaoyan0106 commented Aug 20, 2024

Fix validation file_size issues

Related tickets

Updates description

  1. fix bug: files without file size pass validation
  2. use "metric" MB/GB for file size calculation
    • 1MB = 100,000 Bytes
    • 1GB = 1,000,000,000 Bytes
  3. update minimum file size cutoff
    • WGS/WXS: 1GB
      • for example: the file_size of this wxs cram is 2G: s3://d3b-study-us-east-1-prd-sd-z7r9svga/pnoc022/source/PMLBM000ESR_PMCRZ389QWO_WXS.cram
    • Other sequencing experiment: 200M
  4. support input file size formats in bytes, megabytes, and gigabytes:
    example acceptable file size values:
    • 100
    • 100M
    • 100MB
    • 10G
    • 10GB

d3b_dff_cli/modules/validation/check_manifest.py Outdated Show resolved Hide resolved
d3b_dff_cli/modules/validation/check_manifest.py Outdated Show resolved Hide resolved
d3b_dff_cli/modules/validation/check_manifest.py Outdated Show resolved Hide resolved
@HuangXiaoyan0106 HuangXiaoyan0106 merged commit a3aa8bf into master Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants